def copy( variable ):
return variable
Decade old code, used in 2 places to "copy" a float and a string. No one wants to touch the working code.
// Is this valid?
function validateStockInItems() {
if (stockInItemsToUpdate.length === 0)
return true;
return true;
}Found in a legacy code base for a stock management system. I will be rewriting said system soon.
<?php
private function redirectFromOldSlug($pSlug, $pLanguageCode)
{
/*
$redirectArray[3][1] = 'beauty-young';
$redirectArray[3][2] = 'beauty-and-rejuvenation';
$redirectArray[3][3] = 'beauty-young';
$redirectArray[3][4] = 'beauty-young';
$redirectArray[2][1] = 'beauty-slim';
$redirectArray[2][2] = 'beauty-slim';
$redirectArray[2][3] = 'beauty-slim';
$redirectArray[2][4] = 'beauty-slim';
$redirectArray[18][1] = 'white-smile---2-dniowy-pakiet';
$redirectArray[18][2] = 'white-smile-2---day-package-hilton-hotel';
$redirectArray[18][3] = 'white-smile';
$redirectArray[18][4] = 'white-smile---2---day-package';
$redirectArray[17][1] = 'zdrowie-z-pieknem';
$redirectArray[17][2] = 'healthy-and-beauty-2---day-with-dentist-botox';
$redirectArray[17][3] = 'gesundheit-von-schonheit-2-tage';
$redirectArray[17][4] = 'vard-av-skonhet-2-dagar';
$redirectArray[19][1] = 'beauty-care';
$redirectArray[19][2] = 'beauty-care';
$redirectArray[19][3] = 'beauty-care';
$redirectArray[19][4] = 'beauty-care';
$redirectArray[21][1] = 'luksus-spa---hilton-w-gdasku';
$redirectArray[21][2] = 'spa-in-hilton-hotel';
$redirectArray[21][3] = 'spa-im-hilton---fur-sie';
$redirectArray[21][4] = 'spa-pa-hilton---for-dig';
$redirectArray[26][1] = 'zabiegi-implantacji-w-sea-tower';
$redirectArray[26][2] = 'implant-treatments-in-the-sea-tower';
$redirectArray[26][3] = 'implantate-in-der-sea-tower';
$redirectArray[26][4] = 'implantat-i-sea-tower';
$redirectArray[23][1] = 'mezoterapia-peeling-lipoliza-botox-hialuron';
$redirectArray[23][2] = 'beauty-med';
$redirectArray[23][3] = 'beauty-med';
$redirectArray[23][4] = 'beauty-med';
$redirectArray[34][1] = 'paski-brzuch-w-8-dni';
$redirectArray[34][2] = 'special-abdomen-programme';
$redirectArray[34][3] = 'das-speziell-gestaltete-und-vorbereitete-programm';
$redirectArray[34][4] = 'ett-speciellt-utformat-program';
$redirectArray[27][1] = 'zdrowy-kregosup';
$redirectArray[27][2] = 'healthy-spine-clinic';
$redirectArray[27][3] = 'wirbelsaule-ist-die-basis';
$redirectArray[27][4] = 'frisk-ryggrad';
$redirectArray[5][1] = 'pakiet-stomatologiczny-hotel-hilton';
$redirectArray[5][2] = 'healthy-smile-2-day-dental-package-hilton-hotel';
$redirectArray[5][3] = 'healthy-smile-2---day---dental-package-hotel-hilton';
$redirectArray[5][4] = 'healthy-smile-2---day---dental-package-hotel-hilton';
$redirectArray[16][1] = 'beauty-calming--anti-redness-2-dni';
$redirectArray[16][2] = 'beauty-calming--anti-redness-2-days';
$redirectArray[16][3] = 'beauty-calming--anti-redness';
$redirectArray[16][4] = 'beauty-calming--anti-redness';
$redirectArray[22][1] = 'stomatolog-na-twoja-kiesze';
$redirectArray[22][2] = 'dentist-for-every-pocket';
$redirectArray[22][3] = 'zahnarzt-fur-jedes-budget';
$redirectArray[22][4] = 'tandlakare-for-varje-budget';
$redirectArray[25][1] = 'przeglad-stomatologiczny-wybielanie-zebow';
$redirectArray[25][2] = 'teeth-whitening';
$redirectArray[25][3] = 'zahnaufhellung';
$redirectArray[25][4] = 'tandblekning';
$redirectArray[24][1] = 'implant-w-dwa-dni';
$redirectArray[24][2] = 'lifelong-guarantee-for-implants';
$redirectArray[24][3] = 'lebenslange-garantie-fur-implantate';
$redirectArray[24][4] = 'livslangt-garanti-for-implantat';
$redirectArray[39][1] = 'nogi-bez-zylakow';
$redirectArray[39][2] = 'varicose';
$redirectArray[39][3] = 'das-venefit-verfahren';
$redirectArray[39][4] = 'forfarande-venefit';
$redirectArray[36][1] = 'rehabilitacja-narzadu-ruch';
$redirectArray[36][2] = 'locomotor-system-14-day-stay-in-the-health-resort';
$redirectArray[36][3] = 'rehabilitation-14-tage-aufenthalt-im-sanatorium';
$redirectArray[36][4] = 'rorelseapparaten---rehabiliteringsemester';
$redirectArray[35][1] = 'zdrowe-serce-14-dniowy-program';
$redirectArray[35][2] = 'cardiology-14-day-stay-in-the-health-resort';
$redirectArray[35][3] = 'kardiologie---14-tage-aufenthalt-im-sanatorium';
$redirectArray[35][4] = 'kardiologi---rehabiliteringsemester';
$redirectArray[37][1] = 'stomatolog-w-szczecinie';
$redirectArray[37][2] = 'dentist-in-szczecin';
$redirectArray[37][3] = 'zahnarzt-in-szczecin';
$redirectArray[37][4] = 'tandlakare-i-szczecin';
$redirectArray[32][1] = 'sanatorium-z-rehabilitacja-narza';
$redirectArray[32][2] = 'physical-medicine-and-rehabilita';
$redirectArray[32][3] = 'rehabilitation-bewegungs';
$redirectArray[32][4] = 'rehabilitation-behandlingar';
*
*/
$redirectArray = array();
$redirectArray['beauty-young']['pl'] = 3;
$redirectArray['beauty-slim']['pl'] = 2;
$redirectArray['white-smile---2-dniowy-pakiet']['pl'] = 18;
$redirectArray['zdrowie-z-pieknem']['pl'] = 17;
$redirectArray['beauty-care']['pl'] = 19;
$redirectArray['luksus-spa---hilton-w-gdasku']['pl'] = 21;
$redirectArray['zabiegi-implantacji-w-sea-tower']['pl'] = 26;
$redirectArray['mezoterapia-peeling-lipoliza-botox-hialuron']['pl'] = 23;
$redirectArray['paski-brzuch-w-8-dni']['pl'] = 34;
$redirectArray['zdrowy-kregosup']['pl'] = 27;
$redirectArray['pakiet-stomatologiczny-hotel-hilton']['pl'] = 5;
$redirectArray['beauty-calming--anti-redness-2-dni']['pl'] = 16;
$redirectArray['stomatolog-na-twoja-kiesze']['pl'] = 22;
$redirectArray['przeglad-stomatologiczny-wybielanie-zebow']['pl'] = 25;
$redirectArray['implant-w-dwa-dni']['pl'] = 24;
$redirectArray['nogi-bez-zylakow']['pl'] = 39;
$redirectArray['rehabilitacja-narzadu-ruch']['pl'] = 36;
$redirectArray['zdrowe-serce-14-dniowy-program']['pl'] = 35;
$redirectArray['stomatolog-w-szczecinie']['pl'] = 37;
$redirectArray['sanatorium-z-rehabilitacja-narza']['pl'] = 32;
$redirectArray['beauty-and-rejuvenation']['en'] = 3;
$redirectArray['beauty-slim']['en'] = 2;
$redirectArray['white-smile-2---day-package-hilton-hotel']['en'] = 18;
$redirectArray['healthy-and-beauty-2---day-with-dentist-botox']['en'] = 17;
$redirectArray['beauty-care']['en'] = 19;
$redirectArray['spa-in-hilton-hotel']['en'] = 21;
$redirectArray['implant-treatments-in-the-sea-tower']['en'] = 26;
$redirectArray['beauty-med']['en'] = 23;
$redirectArray['special-abdomen-programme']['en'] = 34;
$redirectArray['healthy-spine-clinic']['en'] = 27;
$redirectArray['healthy-smile-2-day-dental-package-hilton-hotel']['en'] = 5;
$redirectArray['beauty-calming--anti-redness-2-days']['en'] = 16;
$redirectArray['dentist-for-every-pocket']['en'] = 22;
$redirectArray['teeth-whitening']['en'] = 25;
$redirectArray['lifelong-guarantee-for-implants']['en'] = 24;
$redirectArray['varicose']['en'] = 39;
$redirectArray['locomotor-system-14-day-stay-in-the-health-resort']['en'] = 36;
$redirectArray['cardiology-14-day-stay-in-the-health-resort']['en'] = 35;
$redirectArray['dentist-in-szczecin']['en'] = 37;
$redirectArray['physical-medicine-and-rehabilita']['en'] = 32;
$redirectArray['beauty-young']['de'] = 3;
$redirectArray['beauty-slim']['de'] = 2;
$redirectArray['white-smile']['de'] = 18;
$redirectArray['gesundheit-von-schonheit-2-tage']['de'] = 17;
$redirectArray['beauty-care']['de'] = 19;
$redirectArray['spa-im-hilton---fur-sie']['de'] = 21;
$redirectArray['implantate-in-der-sea-tower']['de'] = 26;
$redirectArray['beauty-med']['de'] = 23;
$redirectArray['das-speziell-gestaltete-und-vorbereitete-programm']['de'] = 34;
$redirectArray['wirbelsaule-ist-die-basis']['de'] = 27;
$redirectArray['healthy-smile-2---day---dental-package-hotel-hilton']['de'] = 5;
$redirectArray['beauty-calming--anti-redness']['de'] = 16;
$redirectArray['zahnarzt-fur-jedes-budget']['de'] = 22;
$redirectArray['zahnaufhellung']['de'] = 25;
$redirectArray['lebenslange-garantie-fur-implantate']['de'] = 24;
$redirectArray['das-venefit-verfahren']['de'] = 39;
$redirectArray['rehabilitation-14-tage-aufenthalt-im-sanatorium']['de'] = 36;
$redirectArray['kardiologie---14-tage-aufenthalt-im-sanatorium']['de'] = 35;
$redirectArray['zahnarzt-in-szczecin']['de'] = 37;
$redirectArray['rehabilitation-bewegungs']['de'] = 32;
$redirectArray['beauty-young']['sv'] = 3;
$redirectArray['beauty-slim']['sv'] = 2;
$redirectArray['white-smile---2---day-package']['sv'] = 18;
$redirectArray['vard-av-skonhet-2-dagar']['sv'] = 17;
$redirectArray['beauty-care']['sv'] = 19;
$redirectArray['spa-pa-hilton---for-dig']['sv'] = 21;
$redirectArray['implantat-i-sea-tower']['sv'] = 26;
$redirectArray['beauty-med']['sv'] = 23;
$redirectArray['ett-speciellt-utformat-program']['sv'] = 34;
$redirectArray['frisk-ryggrad']['sv'] = 27;
$redirectArray['healthy-smile-2---day---dental-package-hotel-hilton']['sv'] = 5;
$redirectArray['beauty-calming--anti-redness']['sv'] = 16;
$redirectArray['tandlakare-for-varje-budget']['sv'] = 22;
$redirectArray['tandblekning']['sv'] = 25;
$redirectArray['livslangt-garanti-for-implantat']['sv'] = 24;
$redirectArray['forfarande-venefit']['sv'] = 39;
$redirectArray['rorelseapparaten---rehabiliteringsemester']['sv'] = 36;
$redirectArray['kardiologi---rehabiliteringsemester']['sv'] = 35;
$redirectArray['tandlakare-i-szczecin']['sv'] = 37;
$redirectArray['rehabilitation-behandlingar']['sv'] = 32;
if (!empty($redirectArray[$pSlug][$pLanguageCode]))
{
$packageId = $redirectArray[$pSlug][$pLanguageCode];
$package = $this->packagesInstance->getPackageByIdAndLang($packageId, $pLanguageCode);
if (!empty($package))
{
$this->redirect('package/'.$package['slug'], array('code' => 301));
}
}
}<?php
foreach (array_keys($values['services']) as $serviceId) {
$service = $this->_em->find('\cut\Entity\Service', $serviceId);
//\Doctrine\Common\Util\Debug::print_r($service); exit();
//$reservation->addService($this->_em->find('\cut\Entity\Service', $serviceId));
$this->view->serviceDeposits[$serviceId] = $service->getDeposit();
}
# checkign if clinic want's bill
$notifications = array();
$reservationServices = array();
foreach (array_keys($values['services']) as $serviceId) {
$reservationServices[$serviceId] = new \cut\Entity\ReservationService();
$service = $this->_em->find('\cut\Entity\Service', $serviceId);
//\Doctrine\Common\Util\Debug::print_r($service); exit();
$reservationServices[$serviceId]->setService($service);
$reservationServices[$serviceId]->setReservation($reservation);
$reservationServices[$serviceId]->setPatient($this->_helper->LoggedUser());
switch ($service->getDeposit()) {
case 'yes':
$reservationServices[$serviceId]->setBillStatus(\cut\Entity\ReservationService::BILL_STATUS_NOT_PAID);
break;
default:
$reservationServices[$serviceId]->setBillStatus(\cut\Entity\ReservationService::BILL_STATUS_NOT_WANTED);
}
$this->view->serviceDeposits[$serviceId] = $service->getDeposit();
}someslice := []*string{
&"fuck",
&"pointers",
}
for i, value := range someSlice {
someSlice[i] = &*value
}if (!empty($tickets)) {
if (count($tickets)) {
$c_start = strtotime($convetion_details['start']);
$c_end = strtotime($convetion_details['end']);
$i = 0;
while ($c_start <= $c_end) {
if (is_int($i / 4) && $i > 0) $convetion_days_html .= '</tr><tr>';
$convetion_days_html .= '<td>' . date('d.m', $c_start) . ' ' . __t($days_of_week[date('w', $c_start)]) . ' <img src="' . str_replace('https', 'http', TEMPLATE_WWWPATH) . '/images/checkbox.png"/></td>';
$c_start = strtotime('+1 day', $c_start);
$i++;
}
//...legacy code from 2007 indians
function formatUpToANumberOfZeroesAfterFloatingPoint(number, numberOfZeroes, floatingPointSymbol) {
numberOfZeroes = (numberOfZeroes === undefined || numberOfZeroes < 0) ? 2 : numberOfZeroes;
floatingPointSymbol = floatingPointSymbol === undefined ? '.' : floatingPointSymbol;
let numberSplitByFloatingPoint = number.toString().split(floatingPointSymbol);
if (numberSplitByFloatingPoint.length !== 2)
return `${number}${floatingPointSymbol}${'0'.repeat(+numberOfZeroes)}`;
let numberAfterFloatingPoint = numberSplitByFloatingPoint[1].toString();
let formattedNumber = `${numberSplitByFloatingPoint[0]}`;
let numberAfterFloatingPointLength = numberAfterFloatingPoint.toString().length;
if (+numberOfZeroes > +numberAfterFloatingPointLength)
return `${formattedNumber}${floatingPointSymbol}${numberAfterFloatingPoint}${'0'.repeat(+numberOfZeroes - numberAfterFloatingPointLength)}`;
let countOfNumbersAfterFloatingPoint = numberAfterFloatingPointLength;
for (var i = numberAfterFloatingPointLength - 1; i >= 0; i--) {
if (+(numberAfterFloatingPoint[i]) !== 0 || +countOfNumbersAfterFloatingPoint === +numberOfZeroes) {
formattedNumber += `${floatingPointSymbol}${numberAfterFloatingPoint.substring(0, countOfNumbersAfterFloatingPoint)}`;
break;
}
countOfNumbersAfterFloatingPoint--;
}
return formattedNumber;
}Well, a junior dev here. A cute female QA came to me with a request - "the field for the price already has precision up to 4 decimal places, but we don't like the 4 ugly zeroes, so if the number ends in zeroes, let it have only 2" - she said in the most innocent-like tone ever known to mankind. How easy I mumbled and accepted the task. As she was leaving she added - "oo almost forgot, we also would like it if all the data fields for the price that are shown in the tables also are formatted that way". As I was watching her better side, while she was getting reunited with her QA tribe, I got shivers down the spine. I had a bad feeling about that one, but I wasn't sure why yet. Suddenly as I was getting up to get a cup of coffe, it dawned on me - "this poor excuse for a project is using jqGrid for displaying the data". To wrap things up - I got a quadruple espresso with a shot of Jacky, developers best friend in a time of need, and came up with this piece of art. Enjoy :)
void function(object* thing)
{
bool enabled = thing && thing->enabled() ? true : false;
...
}switch (numberOfQuestionsToAnswer) {
case 0:
displayGrid1 = false;
displayGrid2 = false;
displayGrid3 = false;
displayGrid4 = false;
displayGrid5 = false;
displayGrid6 = false;
displayGrid7 = false;
displayGrid8 = false;
displayGrid9 = false;
displayGrid10 = false;
break;
case 1:
displayAnsInputTextBox1 = displayPreselectedAnsBox();
displayGrid1 = true;
break;
case 2:
displayAnsInputTextBox1 = displayPreselectedAnsBox();
displayAnsInputTextBox2 = displayPreselectedAnsBox();
displayGrid1 = true;
displayGrid2 = true;
break;
case 3:
displayAnsInputTextBox1 = displayPreselectedAnsBox();
displayAnsInputTextBox2 = displayPreselectedAnsBox();
displayAnsInputTextBox3 = displayPreselectedAnsBox();
displayGrid1 = true;
displayGrid2 = true;
displayGrid3 = true;
break;
case 4:
displayAnsInputTextBox1 = displayPreselectedAnsBox();
displayAnsInputTextBox2 = displayPreselectedAnsBox();
displayAnsInputTextBox3 = displayPreselectedAnsBox();
displayAnsInputTextBox4 = displayPreselectedAnsBox();
displayGrid1 = true;
displayGrid2 = true;
displayGrid3 = true;
displayGrid4 = true;
break;
case 5:
displayAnsInputTextBox1 = displayPreselectedAnsBox();
displayAnsInputTextBox2 = displayPreselectedAnsBox();
displayAnsInputTextBox3 = displayPreselectedAnsBox();
displayAnsInputTextBox4 = displayPreselectedAnsBox();
displayAnsInputTextBox5 = displayPreselectedAnsBox();
displayGrid1 = true;
displayGrid2 = true;
displayGrid3 = true;
displayGrid4 = true;
displayGrid5 = true;
break;
case 6:
displayAnsInputTextBox1 = displayPreselectedAnsBox();
displayAnsInputTextBox2 = displayPreselectedAnsBox();
displayAnsInputTextBox3 = displayPreselectedAnsBox();
displayAnsInputTextBox4 = displayPreselectedAnsBox();
displayAnsInputTextBox5 = displayPreselectedAnsBox();
displayAnsInputTextBox6 = displayPreselectedAnsBox();
displayGrid1 = true;
displayGrid2 = true;
displayGrid3 = true;
displayGrid4 = true;
displayGrid5 = true;
displayGrid6 = true;
break;
case 7:
displayAnsInputTextBox1 = displayPreselectedAnsBox();
displayAnsInputTextBox2 = displayPreselectedAnsBox();
displayAnsInputTextBox3 = displayPreselectedAnsBox();
displayAnsInputTextBox4 = displayPreselectedAnsBox();
displayAnsInputTextBox5 = displayPreselectedAnsBox();
displayAnsInputTextBox6 = displayPreselectedAnsBox();
displayAnsInputTextBox7 = displayPreselectedAnsBox();
displayGrid1 = true;
displayGrid2 = true;
displayGrid3 = true;
displayGrid4 = true;
displayGrid5 = true;
displayGrid6 = true;
displayGrid7 = true;
break;
case 8:
displayAnsInputTextBox1 = displayPreselectedAnsBox();
displayAnsInputTextBox2 = displayPreselectedAnsBox();
displayAnsInputTextBox3 = displayPreselectedAnsBox();
displayAnsInputTextBox4 = displayPreselectedAnsBox();
displayAnsInputTextBox5 = displayPreselectedAnsBox();
displayAnsInputTextBox6 = displayPreselectedAnsBox();
displayAnsInputTextBox7 = displayPreselectedAnsBox();
displayAnsInputTextBox8 = displayPreselectedAnsBox();
displayGrid1 = true;
displayGrid2 = true;
displayGrid3 = true;
displayGrid4 = true;
displayGrid5 = true;
displayGrid6 = true;
displayGrid7 = true;
displayGrid8 = true;
break;
case 9:
displayAnsInputTextBox1 = displayPreselectedAnsBox();
displayAnsInputTextBox2 = displayPreselectedAnsBox();
displayAnsInputTextBox3 = displayPreselectedAnsBox();
displayAnsInputTextBox4 = displayPreselectedAnsBox();
displayAnsInputTextBox5 = displayPreselectedAnsBox();
displayAnsInputTextBox6 = displayPreselectedAnsBox();
displayAnsInputTextBox7 = displayPreselectedAnsBox();
displayAnsInputTextBox8 = displayPreselectedAnsBox();
displayAnsInputTextBox9 = displayPreselectedAnsBox();
displayGrid1 = true;
displayGrid2 = true;
displayGrid3 = true;
displayGrid4 = true;
displayGrid5 = true;
displayGrid6 = true;
displayGrid7 = true;
displayGrid8 = true;
displayGrid9 = true;
break;
case 10:
displayAnsInputTextBox1 = displayPreselectedAnsBox();
displayAnsInputTextBox2 = displayPreselectedAnsBox();
displayAnsInputTextBox3 = displayPreselectedAnsBox();
displayAnsInputTextBox4 = displayPreselectedAnsBox();
displayAnsInputTextBox5 = displayPreselectedAnsBox();
displayAnsInputTextBox6 = displayPreselectedAnsBox();
displayAnsInputTextBox7 = displayPreselectedAnsBox();
displayAnsInputTextBox8 = displayPreselectedAnsBox();
displayAnsInputTextBox9 = displayPreselectedAnsBox();
displayAnsInputTextBox10 = displayPreselectedAnsBox();
displayGrid1 = true;
displayGrid2 = true;
displayGrid3 = true;
displayGrid4 = true;
displayGrid5 = true;
displayGrid6 = true;
displayGrid7 = true;
displayGrid8 = true;
displayGrid9 = true;
displayGrid10 = true;
break;
}This was for a wizard type questionnaire where there could be up to 10 questions.
o.isInsured = function ()
{ return !!this.insured; }
Why don't be like normal people and use bool() cast?
checkParameter(elem: boolean): any {
if(elem) return true;
return null;
}int t;
if ((t > 1) && (t < 2))
{
errorString = errorBuffer;
return -1;
}int i=0;
for (i=0; i<msg.length;i++){
switch (i){
case 0:
case 1:
case 2:
case 3:
case 4:
case 5:
case 6:
case 7:
case 8:
case 9:
case 10:
case 11:
case 18:
case 19:
case 26:
case 27:
case 34:
case 35:
case 42:
case 43:
case 50:
case 51:
case 52:
case 53:
case 54:
case 55:
case 58:
case 59:
case 62:
case 63: log.debug("******** TRAZA-BEA: autenticacion ntlm. mensaje[" + i + "]: " + msg[i] + " SINSIGNO: " + (int)(msg[i] & 0x00ff) + " " + new String(msg,i,1, "UTF-16LE")); break;
case 12:
case 14:
case 16:
case 20:
case 22:
case 24:
case 28:
case 30:
case 32:
case 36:
case 38:
case 40:
case 44:
case 46:
case 48:
case 56:
case 60:log.debug("******** TRAZA-BEA: autenticacion ntlm. mensaje[" + i + "]: " + msg[i] + " SINSIGNO: " + (int)(msg[i] & 0x00ff) + " " + new String(msg,i,2, "UTF-16LE")); break;
case 13:
case 15:
case 17:
case 21:
case 23:
case 25:
case 29:
case 31:
case 33:
case 37:
case 39:
case 41:
case 45:
case 47:
case 49:
case 57:
Why not case 60? LOL
$d = explode(".",$request->get("due_date",".."));
foreach ($d as $key => $val) $d[$key]=(int)$val;
if (
!is_numeric($d[0]) || $d[0]<1 ||$d[0]>31 ||
!is_numeric($d[1]) || $d[1]<1 ||$d[1]>12 ||
!is_numeric($d[2]) || $d[2]<2005 ||$d[2]>2100 ) {
$error["due_date"] = "Missing date.";
}I think this was the last piece of code the developer wrote .... :D
bool b = connection.isConnected() == true ? true : false;My first internship presented me with this.